Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

traffic light badge + minor readme change #253

Merged
merged 2 commits into from
Sep 13, 2024
Merged

traffic light badge + minor readme change #253

merged 2 commits into from
Sep 13, 2024

Conversation

AUdaltsova
Copy link
Contributor

Pull Request

Description

  • added traffic light badge (placement up for dispute, I'm not entirely happy with that and would rather put it on the right but can't figure out how to keep them aligned... oh well)
  • added warning that icon doesn't work out of the box

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@codecov Codecov
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (bdbe00a) to head (f358681).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   59.00%   59.00%           
=======================================
  Files          29       29           
  Lines        1893     1893           
=======================================
  Hits         1117     1117           
  Misses        776      776

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AUdaltsova AUdaltsova changed the title traffic light badge + minor fixes traffic light badge + minor readme change Sep 13, 2024
@AUdaltsova AUdaltsova merged commit 76651e9 into main Sep 13, 2024
3 checks passed
@AUdaltsova AUdaltsova deleted the readme-upd branch September 13, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AUdaltsova @peterdudfield